Oh crap I think there was a misunderstanding. I tried to say in #74 that all of the tutorials in the pull request were now working. That's a lot of duplicated tedious work. I'm really sorry about not making that more clear. I will compare your new notebooks to my new notebooks and we can figure out how to move forward.

Most of the changes that are not notebook related should go into a separate PR. Adding the ability to save SAM files via the retrieve_sam function is interesting but will need to be discussed.

I briefly looked at your notebooks that show zenith and airmass calculations. The calculations seemed ok to me: zenith angles are between 0 and 180 degrees, and airmass is only defined for zenith angles less than 90 degrees. What's not ok is that I accidentally made a plot (atmosphere cell 6) that labels airmass as zenith.

Will & Co

no problem, I should have read more carefully. I think it is easiest if
you just ignore my changes, yours are probably more comprehensive. I have
to apologise for not bringing my contribution in time.

Not related to this matter, I must say goodbye. It became clear to me over
the weekend that personal obligations do not allow me to make a significant
contribution to this very exciting project. I just cannot make enough time
available without sacrificing in other areas. Perhaps later....

thanks for your warm and friendly attitude, this is a really nice team and
I really appreciate your ettiquete and kindness!

Go well and good luck.

On 12 July 2015 at 21:52, Will Holmgren [email protected] wrote:

Oh crap I think there was a misunderstanding. I tried to say in #74
#74 that all of the tutorials
in the pull request were now working. That's a lot of duplicated tedious
work. I'm really sorry about not making that more clear. I will compare
your new notebooks to my new notebooks and we can figure out how to move
forward.

Most of the changes that are not notebook related should go into a
separate PR. Adding the ability to save SAM files via the retrieve_sam
function is interesting but will need to be discussed.

I briefly looked at your notebooks that show zenith and airmass
calculations. The calculations seemed ok to me: zenith angles are between 0
and 180 degrees, and airmass is only defined for zenith angles less than 90
degrees. What's not ok is that I accidentally made a plot (atmosphere cell
6) that labels airmass as zenith.

—
Reply to this email directly or view it on GitHub
#78 (comment).

@NelisW I'm sorry to see you go and I hope we can work together again in the future!